Manage the statistics target for a deployment #4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
force-pushed
the
lutter/stats-target
branch
from
0637ce0 to
36a3bcf
Compare
tilacog
reviewed
Nov 21, 2022
store/postgres/src/relational.rs
Outdated
Comment on lines
165
to
170
| impl Borrow<str> for SqlName { | ||
| fn borrow(&self) -> &str { | ||
| self.as_str() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't need to implement Borrow<str> for SqlName, only for &SqlName.
Suggested change
| impl Borrow<str> for SqlName { | |
| fn borrow(&self) -> &str { | |
| self.as_str() | |
| } | |
| } |
There was a problem hiding this comment.
Nice catch. Taking that out.
tilacog
reviewed
Nov 21, 2022
Comment on lines
+187
to
+191
| let columns = if columns.is_empty() { | ||
| vec!["id".to_string(), "block_range".to_string()] | ||
| } else { | ||
| columns | ||
| }; |
There was a problem hiding this comment.
Two questions:
- Should
idandblock_rangealways be included? - What about
vid?
There was a problem hiding this comment.
I haven't seen vid be useful here, that's why I left it out. And I felt that not adding to a list of user-provided columns is more understandable than always adding them.
tilacog
approved these changes
Nov 21, 2022
lutter
force-pushed
the
lutter/stats-target
branch
from
36a3bcf to
9435720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show, set or reset the target for a deployment. The statistics target determines how much of a table Postgres will sample when it analyzes a table. This can be particularly beneficial when Postgres chooses suboptimal query plans for some queries. Increasing the target will make analyzing tables take longer and will require more space in Postgres' internal statistics storage.
See also https://www.postgresql.org/docs/15/planner-stats.html#id-1.5.13.5.3