Remove MetricsRegistryTrait and use just struct MetricsRegistry
#4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neysofu
force-pushed
the
filippo/rm-metrics-registry-trait
branch
from
c2c5560 to
054347b
Compare
lutter
approved these changes
Mar 17, 2023
neysofu
force-pushed
the
filippo/rm-metrics-registry-trait
branch
from
054347b to
5ec722f
Compare
gusinacio
pushed a commit
to gusinacio/graph-node
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4438. See also #4443, which recently touched on some of this code.
It's all in one big commit, apologies, as I didn't know how to best break it up into smaller pieces. The only changes are pretty much:
MetricsRegistryTraitand add its default method implementations toMetricsRegistry.