Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraph composition spec version #5782

Open
wants to merge 1 commit into
base: zoran/subgraph-composition-rework-vid-wrap2
Choose a base branch
from

Conversation

zorancv
Copy link
Contributor

@zorancv zorancv commented Jan 23, 2025

This PR aims to base VID generation on spec_version so that both old and new way of generating VID will work simultaneously in the single binary. Some code that was removed in #5737 is reintroduced here.

@zorancv zorancv self-assigned this Jan 23, 2025
@zorancv zorancv changed the base branch from master to zoran/subgraph-composition-rework-vid-wrap2 January 23, 2025 16:23
@zorancv zorancv marked this pull request as ready for review January 23, 2025 16:29
@zorancv zorancv marked this pull request as draft January 23, 2025 16:30
@zorancv zorancv changed the base branch from zoran/subgraph-composition-rework-vid-wrap2 to zoran/rename-structs January 27, 2025 16:21
@zorancv zorancv changed the base branch from zoran/rename-structs to zoran/subgraph-composition-rework-vid-wrap2 January 27, 2025 16:24
@zorancv zorancv marked this pull request as ready for review January 27, 2025 16:56
@zorancv zorancv requested a review from lutter January 27, 2025 16:56
@zorancv zorancv marked this pull request as draft January 28, 2025 15:46
@zorancv zorancv force-pushed the zoran/subgraph-composition-spec-version branch 6 times, most recently from d8bea9d to 47176c8 Compare January 28, 2025 22:20
@zorancv zorancv marked this pull request as ready for review January 28, 2025 23:52
@zorancv zorancv force-pushed the zoran/subgraph-composition-spec-version branch 2 times, most recently from 81f0a57 to 133169c Compare January 29, 2025 00:04
@zorancv zorancv force-pushed the zoran/subgraph-composition-rework-vid-wrap2 branch 4 times, most recently from 961556b to a49edb8 Compare January 29, 2025 16:35
@zorancv zorancv force-pushed the zoran/subgraph-composition-spec-version branch 2 times, most recently from 6cb3a0c to 3d25869 Compare January 30, 2025 17:05
graph/src/components/store/entity_cache.rs Outdated Show resolved Hide resolved
store/postgres/src/relational/prune.rs Outdated Show resolved Hide resolved
graph/src/schema/entity_type.rs Outdated Show resolved Hide resolved
@zorancv zorancv force-pushed the zoran/subgraph-composition-spec-version branch 2 times, most recently from e05ae82 to 522d7f7 Compare January 31, 2025 07:53
@incrypto32 incrypto32 added this to the Subgraph Composition milestone Jan 31, 2025
@incrypto32 incrypto32 force-pushed the zoran/subgraph-composition-rework-vid-wrap2 branch from 515fdbc to e61452f Compare January 31, 2025 14:19
@incrypto32 incrypto32 force-pushed the zoran/subgraph-composition-spec-version branch from e5d997b to c8d8103 Compare January 31, 2025 14:22
@incrypto32 incrypto32 force-pushed the zoran/subgraph-composition-rework-vid-wrap2 branch from e61452f to 1cb3401 Compare January 31, 2025 15:22
@zorancv zorancv force-pushed the zoran/subgraph-composition-rework-vid-wrap2 branch 3 times, most recently from 7173051 to 46fa0f4 Compare February 2, 2025 09:28
@zorancv zorancv force-pushed the zoran/subgraph-composition-spec-version branch from c8d8103 to a6b7647 Compare February 2, 2025 10:09
@incrypto32 incrypto32 force-pushed the zoran/subgraph-composition-rework-vid-wrap2 branch from 46fa0f4 to 061b9c7 Compare February 3, 2025 09:10
@incrypto32 incrypto32 force-pushed the zoran/subgraph-composition-spec-version branch from a6b7647 to 9fa915b Compare February 3, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants