-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subgraph composition spec version #5782
Open
zorancv
wants to merge
1
commit into
zoran/subgraph-composition-rework-vid-wrap2
Choose a base branch
from
zoran/subgraph-composition-spec-version
base: zoran/subgraph-composition-rework-vid-wrap2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Subgraph composition spec version #5782
zorancv
wants to merge
1
commit into
zoran/subgraph-composition-rework-vid-wrap2
from
zoran/subgraph-composition-spec-version
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorancv
changed the base branch from
master
to
zoran/subgraph-composition-rework-vid-wrap2
January 23, 2025 16:23
zorancv
changed the base branch from
zoran/subgraph-composition-rework-vid-wrap2
to
zoran/rename-structs
January 27, 2025 16:21
zorancv
changed the base branch from
zoran/rename-structs
to
zoran/subgraph-composition-rework-vid-wrap2
January 27, 2025 16:24
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
6 times, most recently
from
January 28, 2025 22:20
d8bea9d
to
47176c8
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
2 times, most recently
from
January 29, 2025 00:04
81f0a57
to
133169c
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
4 times, most recently
from
January 29, 2025 16:35
961556b
to
a49edb8
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
2 times, most recently
from
January 30, 2025 17:05
6cb3a0c
to
3d25869
Compare
lutter
approved these changes
Jan 31, 2025
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
2 times, most recently
from
January 31, 2025 07:53
e05ae82
to
522d7f7
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
from
January 31, 2025 14:19
515fdbc
to
e61452f
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-spec-version
branch
from
January 31, 2025 14:22
e5d997b
to
c8d8103
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
from
January 31, 2025 15:22
e61452f
to
1cb3401
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
3 times, most recently
from
February 2, 2025 09:28
7173051
to
46fa0f4
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
from
February 2, 2025 10:09
c8d8103
to
a6b7647
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
from
February 3, 2025 09:10
46fa0f4
to
061b9c7
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-spec-version
branch
from
February 3, 2025 09:12
a6b7647
to
9fa915b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to base
VID
generation onspec_version
so that both old and new way of generatingVID
will work simultaneously in the single binary. Some code that was removed in #5737 is reintroduced here.