This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Add JSON utils for returning kinds, valid utf8, and kinds to strings #116

Open

davekaj wants to merge 1 commit into main from dave/add-json-utils

Contributor

davekaj commented Jun 8, 2020

Found these here: https://github.com/nanspro/kauri-subgraph/blob/master/src/util.ts

Untested. Opening the PR to make us aware of it
I am found of them all, except kindToString() - not too sure if this is useful enough to be in the library
isValidUTF8() looks great, but I am unaware of how it currently works
Would be nice to add in for asBigInt() and asI32()

What do you guys think? @Jannis @leoyvens

davekaj requested review from Jannis and leoyvens

June 8, 2020 00:13


          Add JSON utils for returning kinds, and valid utf8

2d7768c

davekaj force-pushed the dave/add-json-utils branch from 49490ae to 2d7768c Compare

June 8, 2020 00:14

Collaborator

leoyvens commented Jun 10, 2020

The as* APIs for JSON seem useful, but they should be put directly under JSONValue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet