This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
common: more native types support for BigInt and ByteArray #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added BigInt.fromU64, BigInt.fromI64 and BigInt.fromU32 as well as corresponding on ByteArray and `toU64`, `toI64` method methods Refactored test.js file at the same time to use recent Node.js features to reduce the code and make the asynchronous operation use `async/await`. Error are properly reported in test now with a link to the failed assertion and a message if provided.
evaporei
reviewed
Oct 27, 2021
evaporei
reviewed
Oct 27, 2021
evaporei
reviewed
Oct 27, 2021
evaporei
reviewed
Oct 27, 2021
evaporei
reviewed
Oct 27, 2021
evaporei
reviewed
Oct 27, 2021
evaporei
reviewed
Oct 27, 2021
evaporei
reviewed
Oct 27, 2021
evaporei
approved these changes
Oct 27, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added BigInt.fromU64, BigInt.fromI64 and BigInt.fromU32 as well as corresponding on ByteArray and
toU64,toI64method methodsRefactored test.js file at the same time to use recent Node.js features to reduce the code and make the asynchronous operation use
async/await. Error are properly reported in test now with a link to the failed assertion and a message if provided.