This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
Tendermint integration #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate tendermint types
Update Tendermint definitions
Use camel case in Tendermint definitions
Update the `EventData` type
fixes linting errors - Graph 114
Fixes missing Tendermint tests
evaporei
approved these changes
Feb 10, 2022
leoyvens
reviewed
Feb 17, 2022
| TendermintEventValidatorSetUpdates = 130, | ||
| TendermintDuration = 131, | ||
| TendermintTimestamp = 132, | ||
| TendermintEventData = 133, |
There was a problem hiding this comment.
If we're going to start allocating index ranges for different chains, as we should, this will need to change.
There was a problem hiding this comment.
You mean having multiple enums for each TypeId? (per chain)
There was a problem hiding this comment.
Not multiple enums, but ranges such as numbers 1000-2000 being reserved for tendermint.
There was a problem hiding this comment.
Oh I see, yeah that seems a good idea
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.