This repository has been archived by the owner on Feb 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilacog
force-pushed
the
tiago/receipts-in-mappings
branch
from
March 23, 2022 14:53
65c23bd
to
e7ffbfc
Compare
This was referenced Mar 23, 2022
evaporei
reviewed
Mar 23, 2022
Do you need another review? @tilacog |
If it's Ok for you, it would be awesome! 😁 |
evaporei
reviewed
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've commented on the graph-node
PR about a couple of field names that might require change.
Also I think you need to add the Index
variants here.
tilacog
force-pushed
the
tiago/receipts-in-mappings
branch
from
March 29, 2022 21:28
469e308
to
d8a5602
Compare
Added a couple of PR's with the requested changes. |
evaporei
approved these changes
Mar 30, 2022
evaporei
suggested changes
Mar 30, 2022
Also, the `Event` class now has a `receipt` nullable field.
tilacog
force-pushed
the
tiago/receipts-in-mappings
branch
from
March 30, 2022 23:27
8141b03
to
b1be084
Compare
evaporei
approved these changes
Mar 30, 2022
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new Ethereum types:
TransactionReceipt
Log
Since
apiVersion 0.0.7
, subgraphs can request transaction receipts inside event handlers, so, for now,TransactionReceipt
is stored inEvent.receipt
(which is a nullable field).This also bumps the
npm
version to0.27.0
This PR is a dependency of: