-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
Generate tendermint types
Update Tendermint definitions
Use camel case in Tendermint definitions
Update the `EventData` type
fixes linting errors - Graph 114
Fixes missing Tendermint tests
Graph 256 - Transaction handler
…ns and regenerate them
* update tendermint.ts class * prettier, lint + fix test * update generated file for chain/tendermint * Fix ModeInfo * Change order of class declaration * bump as-proto to v0.2.3 * move all cosmos decoding function in one file * move enum a top of file
remove cosmoshub-4 proto binding
Rename Tendermint to Cosmos
Hey @pienkowb the only thing I think I have to comment on this is that instead of having to use This: export class HeaderOnlyBlock {
public header: Header
constructor(header: Header) {
this.header = header
}
} Is the same as this 🙂 : export class HeaderOnlyBlock {
// doesn't need the property here as well :)
constructor(public header: Header) { /* no code is needed! */ }
} So you can probably simplify the code a bit (if you agree with the change ofc). |
@evaporei I totally agree, your version looks much cleaner 👍 The issue is that we use a generator to create this file, so we would need to update the generator first. Maybe there's some kind of a linter that could do this change automatically? |
I don't think the linter can simplify this one unfortunately. I'll approve/merge this once the |
Add helper methods for extracting event attributes
The |
No description provided.