Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Rename Tendermint to Cosmos #273

Merged
merged 56 commits into from
May 12, 2022
Merged

Conversation

pienkowb
Copy link
Contributor

@pienkowb pienkowb commented May 9, 2022

No description provided.

Patrycja Zawadka and others added 30 commits October 26, 2021 18:27
Use camel case in Tendermint definitions
fixes linting errors - Graph 114
Fixes missing Tendermint tests
Graph 256 - Transaction handler
Patrycja Zawadka and others added 14 commits April 7, 2022 17:16
* update tendermint.ts class
* prettier, lint + fix test
* update generated file for chain/tendermint
* Fix ModeInfo
* Change order of class declaration
* bump as-proto to v0.2.3
* move all cosmos decoding function in one file
* move enum a top of file
@evaporei evaporei self-requested a review May 9, 2022 15:34
@evaporei evaporei self-assigned this May 9, 2022
@evaporei
Copy link
Contributor

evaporei commented May 11, 2022

Hey @pienkowb the only thing I think I have to comment on this is that instead of having to use this on the constructor, in AssemblyScript you can omit if you're just setting the properties.

This:

export class HeaderOnlyBlock {
  public header: Header

  constructor(header: Header) {
    this.header = header
  }
}

Is the same as this 🙂 :

export class HeaderOnlyBlock {
  // doesn't need the property here as well :)
  constructor(public header: Header) { /* no code is needed! */ }
}

So you can probably simplify the code a bit (if you agree with the change ofc).

package-lock.json Outdated Show resolved Hide resolved
@pienkowb
Copy link
Contributor Author

So you can probably simplify the code a bit (if you agree with the change ofc).

@evaporei I totally agree, your version looks much cleaner 👍 The issue is that we use a generator to create this file, so we would need to update the generator first. Maybe there's some kind of a linter that could do this change automatically?

@evaporei
Copy link
Contributor

I don't think the linter can simplify this one unfortunately. I'll approve/merge this once the package-lock.json file is removed 🙂

@pienkowb
Copy link
Contributor Author

I don't think the linter can simplify this one unfortunately. I'll approve/merge this once the package-lock.json file is removed 🙂

The package-lock.json file is now removed. I also modified the generator to use parameter properties :)

@evaporei evaporei merged commit 4c064a8 into graphprotocol:main May 12, 2022
@pienkowb pienkowb deleted the cosmos branch May 17, 2022 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants