-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTPX transport #370
Add HTTPX transport #370
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 24 25 +1
Lines 2215 2321 +106
==========================================
+ Hits 2215 2321 +106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I can't build docs:
|
Signed-off-by: Helder Correia <[email protected]>
Thanks a lot for your complete PR! |
It's because of this issue. |
Thanks, I was able to run locally and fixes already sent!
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the following changes:
- add httpx dependencies in
docs/intro.rst
- add httpx link in
docs/usage/file_upload.rst
- add a file in
docs/modules
for httpx and add it todocs/modules/gql.rst
This should fix the non-working ref in the doc
Please don't use force-push but instead push a normal commit so that we can see the changes more easily.
Do I add the |
In another repository. |
Signed-off-by: Helder Correia <[email protected]>
👍
I'm not a fan of force-pushing except in very rare occurrences. |
Thanks for the quick review and merge! 🎉 |
And thank you again for your help! |
Any ideas when this would be released? |
Thanks @leszekhanusz. Will wait for the final release. |
Fixes #154
This is an alternative to #340.
Notes
Signed-off-by: Helder Correia