Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start raising DeprecationWarnings for using only_fields and exclude_fields (v3) #980

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Start raising DeprecationWarnings for using only_fields and exclude_fields (v3) #980

merged 1 commit into from
Jun 10, 2020

Conversation

DoctorJohn
Copy link
Contributor

As discussed in #691 and planned in #705 this PR starts raising DeprecationWarnings for using only_fields and exclude_fields in v3. Before PendingDepcrecationWarnings were raised.

@ulgens ulgens self-requested a review June 7, 2020 15:23
jkimbo
jkimbo approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkimbo jkimbo merged commit 85976ff into graphql-python:v3 Jun 10, 2020
@jkimbo jkimbo mentioned this pull request Jun 10, 2020
Closed
7 tasks
@cpmsmith cpmsmith mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulgens ulgens ulgens approved these changes

@jkimbo jkimbo jkimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DoctorJohn @ulgens @jkimbo