Use unidecode to handle unicode characters in constant names (#1080)

graphql-python · Feb 8, 2020 · 9a19447 · 9a19447
1 parent 55a03ba
commit 9a19447
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/graphene/utils/str_converters.py b/graphene/utils/str_converters.py
@@ -1,4 +1,5 @@
 import re
+from unidecode import unidecode
 
 
 # Adapted from this response in Stackoverflow
@@ -18,4 +19,4 @@ def to_snake_case(name):
 
 
 def to_const(string):
-    return re.sub(r"[\W|^]+", "_", string).upper()  # noqa
+    return re.sub(r"[\W|^]+", "_", unidecode(string)).upper()
diff --git a/graphene/utils/tests/test_str_converters.py b/graphene/utils/tests/test_str_converters.py
@@ -21,3 +21,7 @@ def test_camel_case():
 
 def test_to_const():
     assert to_const('snakes $1. on a "#plane') == "SNAKES_1_ON_A_PLANE"
+
+
+def test_to_const_unicode():
+    assert to_const("Skoða þetta unicode stöff") == "SKODA_THETTA_UNICODE_STOFF"
diff --git a/setup.py b/setup.py
@@ -86,6 +86,7 @@ def run_tests(self):
         "graphql-core>=3.0.0,<4",
         "graphql-relay>=3.0.0,<4",
         "aniso8601>=6,<9",
+        "unidecode>=1.1.1,<2",
     ],
     tests_require=tests_require,
     extras_require={"test": tests_require, "dev": dev_requires},