enable sonarjs/no-redundant-jump rule

graphql · Dec 5, 2022 · 4ff2794 · 4ff2794
1 parent eb3c556
commit 4ff2794
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.changeset/yellow-kiwis-listen.md b/.changeset/yellow-kiwis-listen.md
@@ -0,0 +1,6 @@
+---
+'@graphiql/react': patch
+'graphql-language-service-server': patch
+---
+
+enable `sonarjs/no-redundant-jump` rule
diff --git a/packages/graphql-language-service-server/src/MessageProcessor.ts b/packages/graphql-language-service-server/src/MessageProcessor.ts
@@ -290,8 +290,6 @@ export class MessageProcessor {
         err?.message ?? err?.toString(),
       );
     }
-
-    return;
   }
 
   _logConfigError(errorMessage: string) {
@@ -541,7 +539,6 @@ export class MessageProcessor {
 
   handleShutdownRequest(): void {
     this._willShutdown = true;
-    return;
   }
 
   handleExitNotification(): void {

diff --git a/packages/graphql-language-service-server/src/findGraphQLTags.ts b/packages/graphql-language-service-server/src/findGraphQLTags.ts
@@ -198,7 +198,6 @@ export function findGraphQLTags(
         }
 
         traverse(node, visitors);
-        return;
       }
     },
     TaggedTemplateExpression: (node: TaggedTemplateExpression) => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -198,7 +198,6 @@ export function findGraphQLTags( @@
             }
             traverse(node, visitors);
-            return;
           }
         },
         TaggedTemplateExpression: (node: TaggedTemplateExpression) => {
@@ Expand Down @@