Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad type definition files in alpha release #1530

Closed
Rugvip opened this issue May 17, 2020 · 2 comments · Fixed by #1534
Closed

Bad type definition files in alpha release #1530

Rugvip opened this issue May 17, 2020 · 2 comments · Fixed by #1534

Comments

@Rugvip
Copy link
Contributor

Rugvip commented May 17, 2020

The .d.ts files in the alpha release contains some bad imports, stemming from the package-relative imports like

import { SizerComponent } from 'src/utility/CodeMirrorSizer';

A couple were fixed in #1487, but there are a few more in the repo.

You likely don't want to set baseUrl here, as that is what allows those imports during type checking of this project, but not in the published package. Although I haven't looked at what impact that will have on the rest of the build.

@acao
Copy link
Member

acao commented May 17, 2020

thank you! i will address this. this import path has been causing a bunch of issues, and I keep forgetting that we've fixed it only in the rewrite

@acao
Copy link
Member

acao commented May 18, 2020

oops, it auto-closed. I'll be kicking out a new release later today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants