-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updating #999 font colors to #666 #1883
fix: updating #999 font colors to #666 #1883
Conversation
🦋 Changeset detectedLatest commit: a81ed75 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
thank you! @Sweetabix1 can you sign the CLA? |
Hi @acao I signed the CLA as an individual contributor but it's still showing for me as 'not covered', is the 'corporate contributor' required? nice work with the project also 🙂 |
@Sweetabix1 :)!! Pinging @brianwarner, do you know why the CLA bot is not authorizing folks who sign as individual contributors? |
Codecov Report
@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
+ Coverage 65.70% 66.40% +0.70%
==========================================
Files 85 86 +1
Lines 5106 5153 +47
Branches 1631 1643 +12
==========================================
+ Hits 3355 3422 +67
+ Misses 1747 1727 -20
Partials 4 4
Continue to review full report at Codecov.
|
Thanks @Sweetabix1, can you try to sign as an individual again? I see a record and I think it's yours, but the name is missing. |
hi @brianwarner, no problem I did it again just now, it should be named & signed in the appropriate places, did it work? |
@Sweetabix1 not sure why it's still not working? @brianwarner do you know perhaps? |
I signed it again just now in case that one might show up 🙂 |
@Sweetabix1 would love to merge this soon! can you add a changeset as per the comment? also, perhaps you authorized the CLA bot using a different github account than the one you used to create this PR? |
@Sweetabix1 ok I've now added the changeset file, and will merge as soon as the tests pass. Sorry about the CLA bot issues! |
thanks for your help on this @Sweetabix1 ! |
Updating font colors for line numbers, comments & brackets from #999 to #666 for accessibility purposes. #666 passes AA accessibility standards for small text, with a contrast ratio of over 5:1.