-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphiql): add react 17, 18 in peerDependencies #1934
Conversation
🦋 Changeset detectedLatest commit: 127e4c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
+ Coverage 65.70% 65.84% +0.13%
==========================================
Files 85 86 +1
Lines 5106 5135 +29
Branches 1631 1638 +7
==========================================
+ Hits 3355 3381 +26
- Misses 1747 1750 +3
Partials 4 4
Continue to review full report at Codecov.
|
I haven’t worked with react 17 or 18 yet, considering we are still using methods which are deprecated in 16, do we know if these versions are compatible with 1.x for certain, before the hooks rewrite? |
Hello @acao , Before I upgraded my Of cause, right after the upgrade of As far as I can see from the React website, they left all the deprecated methods with As for React 18, it hasn't been released yet, so, I can't tell you more about it. Hope, my comment will help you in your decision regarding the PR. |
thanks for your validation! I think we can consider this good to go then! thanks everyone :) |
peerDependencies
ofgraphiql