Adds support for #graphql in the language server

[arcanis]

The #graphql-annotated strings weren't properly detected by the language server:

Fixes graphql/vscode-graphql#294

[changeset-bot]

🦋 Changeset detected

Latest commit: f66abfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
graphql-language-service-server	Patch
graphql-language-service	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Maël Nison (b96aa67)

[n1ru4l]

@arcanis Do you think you could also add auto-complete support for the following?

/* GraphQL */  `
  query foo {
    a
  }
`

[n1ru4l]

@arcanis You should also add a changeset 😇

[arcanis]

Should be fine! :) Can you try running the tests?

[n1ru4l]

@arcanis Unfortunately, I have no rights on this repo :( I already asked in the graphiql discord channel whether anyone can help us out getting this released

[acao]

@n1ru4l I'm not sure how it got to be that my permission is needed to run github actions. I will fix that

@arcanis we are getting this on compile in CI:

findGraphQLTags.ts(14,3): error TS2724: '"../../../node_modules/@babel/types/lib"' has no exported member named 'TemplateExpression'.

if the build is working for you, perhaps you need to update your node modules locally

Also, I need to add development instructions for testing language server changes properly, my bad! Here are some steps to test this locally:

1. clone this repo, yarn and yarn build or yarn watch
2. yarn link inside graphql-language-service-server
3. clone vscode-graphql, yarn and yarn link graphql-language-service-server
4. then follow this: https://github.com/graphql/vscode-graphql#development

this will all be much more straightforward when we merge the extension into the monorepo

[arcanis]

I'm not sure how it got to be that my permission is needed to run github actions. I will fix that

It's a new change in GH's rules. To avoid malicious actors running crypto mining on public repos' workflows, they now require first-time contributors' workflows to be approved manually.

Thanks for the debug steps! I'll give it a look tonight, should be fixed tomorrow 👍

[arcanis]

I made a fix and tsc / eslint pass, but I wasn't able to test it within a packaged extension. Something between vsce and npm link breaks.

[arcanis]

Ping? 😊

[acao]

sorry @arcanis ! hopefully can get to this later this week, more urgent OSS matters happening right now!

[acao]

@stonexer @zth @divyenduz @ardatan anyone want to help me advance this?

[codecov]

Codecov Report

Merging #1941 (f66abfd) into main (2d91916) will increase coverage by 0.18%.
The diff coverage is 68.00%.

@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
+ Coverage   65.70%   65.89%   +0.18%     
==========================================
  Files          85       86       +1     
  Lines        5106     5143      +37     
  Branches     1631     1640       +9     
==========================================
+ Hits         3355     3389      +34     
- Misses       1747     1750       +3     
  Partials        4        4              

Impacted Files	Coverage Δ
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts	50.90% <20.00%> (-8.67%)	⬇️
packages/graphiql/src/utility/HistoryStore.ts	62.26% <62.26%> (ø)
packages/graphiql/src/components/QueryHistory.tsx	73.91% <76.47%> (+6.69%)	⬆️
...iql/src/components/DocExplorer/MarkdownContent.tsx	100.00% <100.00%> (ø)
packages/graphiql/src/components/GraphiQL.tsx	58.34% <100.00%> (+0.83%)	⬆️
...hql-language-service-server/src/findGraphQLTags.ts	67.64% <100.00%> (+7.00%)	⬆️
packages/graphiql/src/utility/QueryStore.ts	42.85% <0.00%> (+2.04%)	⬆️
packages/graphiql/src/components/ToolbarButton.tsx	92.85% <0.00%> (+21.42%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e103cac...f66abfd. Read the comment docs.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Maël Nison (b96aa67, 6767b43, 8e3e945, 88cac9f, b84ef92)
• ✅ Dotan Simha (97947a4, 2bbaebe)

[dotansimha]

Thanks @arcanis ! Awesome work. Sorry for the delay - I fixed the CI issues and we are good to go!