Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codemirror import for onHasCompletion #2265

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Conversation

acao
Copy link
Member

@acao acao commented Mar 31, 2022

Not seeing this in the umd build for whatever reason
https://graphiql-test.netlify.app

however #2263 seems to be occuring for some webpack users, and I suspect this might be a fix?

if cypress passes, then we know that it still works for the umd build at least

Not seeing this in the umd build for whatever reason
https://graphiql-test.netlify.app

however #2263 seems to be occuring for some webpack users, and I suspect this might be a fix?
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2022

🦋 Changeset detected

Latest commit: e2b23fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #2265 (f7b7e4f) into main (2d91916) will decrease coverage by 0.99%.
The diff coverage is 74.00%.

❗ Current head f7b7e4f differs from pull request most recent head e2b23fa. Consider uploading reports for the commit e2b23fa to get more accurate results

@@            Coverage Diff             @@
##             main    #2265      +/-   ##
==========================================
- Coverage   65.70%   64.71%   -1.00%     
==========================================
  Files          85       81       -4     
  Lines        5106     5314     +208     
  Branches     1631     1700      +69     
==========================================
+ Hits         3355     3439      +84     
- Misses       1747     1871     +124     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58bdac0...e2b23fa. Read the comment docs.

@eMerzh
Copy link
Contributor

eMerzh commented Mar 31, 2022

as far as i can test this , is seems to work 🤔

@acao
Copy link
Member Author

acao commented Mar 31, 2022

@eMerzh the netlify build is using umd (for cdn bundle users), and that was already working. let me add a changeset here so that it publishes a canary release for you to try with your specific webpack config

@eMerzh
Copy link
Contributor

eMerzh commented Mar 31, 2022

That would be awesome 😎
But I tried using the debugger in my setup and the fix seems to Work... But ofc it would be clearer with a canary

@acao
Copy link
Member Author

acao commented Mar 31, 2022

@eMerzh oh fantastic, that’s great news! Thanks for testing to that extent! I think we can call this fixed then, if both the umd and esm build are working with this change now!

@acao acao merged commit 9458e10 into main Mar 31, 2022
@acao acao deleted the fix-autocomplete-import branch March 31, 2022 13:49
@github-actions github-actions bot mentioned this pull request Mar 31, 2022
@eMerzh
Copy link
Contributor

eMerzh commented Mar 31, 2022

@acao i can confirm the new release fix it 🙌 ...

Thanks for the reactivity and for your work on this project

@acao
Copy link
Member Author

acao commented Mar 31, 2022

Thanks @eMerzh, and thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants