-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix codemirror
import for onHasCompletion
#2265
Conversation
Not seeing this in the umd build for whatever reason https://graphiql-test.netlify.app however #2263 seems to be occuring for some webpack users, and I suspect this might be a fix?
🦋 Changeset detectedLatest commit: e2b23fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as canary in npm (based on the declared |
Codecov Report
@@ Coverage Diff @@
## main #2265 +/- ##
==========================================
- Coverage 65.70% 64.71% -1.00%
==========================================
Files 85 81 -4
Lines 5106 5314 +208
Branches 1631 1700 +69
==========================================
+ Hits 3355 3439 +84
- Misses 1747 1871 +124
Partials 4 4
Continue to review full report at Codecov.
|
as far as i can test this , is seems to work 🤔 |
@eMerzh the netlify build is using umd (for cdn bundle users), and that was already working. let me add a changeset here so that it publishes a canary release for you to try with your specific webpack config |
That would be awesome 😎 |
@eMerzh oh fantastic, that’s great news! Thanks for testing to that extent! I think we can call this fixed then, if both the umd and esm build are working with this change now! |
@acao i can confirm the new release fix it 🙌 ... Thanks for the reactivity and for your work on this project |
Thanks @eMerzh, and thanks for reporting this! |
Not seeing this in the umd build for whatever reason
https://graphiql-test.netlify.app
however #2263 seems to be occuring for some webpack users, and I suspect this might be a fix?
if cypress passes, then we know that it still works for the umd build at least