Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): use pointer-events:none on Menu dropdown SVG #2388

Merged
merged 1 commit into from
May 5, 2022

Conversation

benjie
Copy link
Member

@benjie benjie commented May 5, 2022

In React 18 the event handling has changed, I believe this is why in React 18 clicking on the specific arrow on the Menu results in no action (whereas clicking the rest of the button works fine). This is easily solved with the pointer-events: none CSS trick for the SVG as used elsewhere.

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2022

🦋 Changeset detected

Latest commit: c302d3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2388 (c302d3f) into main (2d91916) will decrease coverage by 0.92%.
The diff coverage is 74.04%.

@@            Coverage Diff             @@
##             main    #2388      +/-   ##
==========================================
- Coverage   65.70%   64.78%   -0.93%     
==========================================
  Files          85       81       -4     
  Lines        5106     5330     +224     
  Branches     1631     1723      +92     
==========================================
+ Hits         3355     3453      +98     
- Misses       1747     1873     +126     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9074ea7...c302d3f. Read the comment docs.

Copy link
Member

@timsuchanek timsuchanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating that!

@timsuchanek timsuchanek merged commit d3ae074 into main May 5, 2022
@timsuchanek timsuchanek deleted the no-pointer-events-on-menu-svg branch May 5, 2022 20:02
@acao acao mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants