Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad changeset and avoid warnings #2398

Merged
merged 1 commit into from
May 12, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

I added a bad changeset in #2397 that contained ignored packages. This currently breaks the release workflow: https://github.com/graphql/graphiql/runs/6395880044?check_suite_focus=true

I also changed the dependencies in the webpack example to avoid the warnings printed above the error.

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2022

⚠️ No Changeset found

Latest commit: 421d6d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
graphiql Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #2398 (421d6d3) into main (2d91916) will decrease coverage by 0.92%.
The diff coverage is 69.94%.

@@            Coverage Diff             @@
##             main    #2398      +/-   ##
==========================================
- Coverage   65.70%   64.77%   -0.93%     
==========================================
  Files          85       81       -4     
  Lines        5106     5332     +226     
  Branches     1631     1724      +93     
==========================================
+ Hits         3355     3454      +99     
- Misses       1747     1874     +127     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
.../graphiql/src/components/DocExplorer/Directive.tsx 100.00% <ø> (ø)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c470dfb...421d6d3. Read the comment docs.

Copy link
Member

@timsuchanek timsuchanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomasheyenbrock thomasheyenbrock merged commit cb39d02 into graphql:main May 12, 2022
@thomasheyenbrock thomasheyenbrock deleted the fix/bad-changeset branch May 12, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants