move more reusable logic into toolkit package #2401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular we move over:
I also noticed that the
shouldPersistHeaders
property that is part of the fetcher options is never used for anything, and after searching through issues and commit history I found no good reason why they should be in there. (@acao maybe I'm lacking context here?) This PR deprecates it and intends to remove it in the next major version ofgraphiql
.