Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix throwing an error inside the fetcher when there is no AST #2737

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

Fixes #2721

Avoid throwing an error in the fetcher if there is no document AST. This can happen when the query string is empty, it just contains comments or when there is a syntax error. In any case, we always want to actually send the request to the server and let the final parsing and validation take place there.

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2022

🦋 Changeset detected

Latest commit: 5f53c5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphiql/toolkit Patch
@graphiql/react Patch
graphiql Patch
@graphiql/plugin-explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@thomasheyenbrock thomasheyenbrock merged commit 48872a8 into main Sep 2, 2022
@thomasheyenbrock thomasheyenbrock deleted the issues/2721 branch September 2, 2022 12:40
@acao acao mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allows submitting invalid queries
1 participant