feat: maintain DocExplorer stack on schema update #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c09abd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are available as canary in npm (based on the declared |
I assume this is due to the token issues we're facing; hopefully we can get this sorted out soon after tomorrows WG meeting 👍 |
|
@benjie yep, just need my |
|
@benjie just tested manually and it works! thanks for this :) |
acao
reviewed
Feb 19, 2023
| @@ -87,4 +107,134 @@ describe('DocExplorer', () => { | |||
| const errors = container.querySelectorAll('.graphiql-doc-explorer-error'); | |||
| expect(errors).toHaveLength(0); | |||
| }); | |||
| it('maintains nav stack when possible', () => { | |||
acao
approved these changes
Feb 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
I'm not sure what the need for resetting the explorer stack is, so I've raised this PR to begin discussions. I believe that the doc explorer should only be reset when an incompatible schema is loaded, and even then we should aim to keep the compatible parts of the stack where possible. I've attempted to achieve this (and included tests for the same) in this PR.