Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Don't convert single \n to <br> #3414

Merged
merged 6 commits into from
Aug 14, 2024
Merged

style: Don't convert single \n to <br> #3414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
687b28e
Update development instructions
leonardehrenfried Aug 28, 2023
ce09e53
Don't convert single \n to <br>
leonardehrenfried Aug 28, 2023
a6e9612
Add changeset
leonardehrenfried Sep 27, 2023
a81beac
Merge branch 'main' into main
dimaMachina Aug 14, 2024
b4c38d0
Update .changeset/olive-mice-hide.md
dimaMachina Aug 14, 2024
470290c
Merge branch 'graphiql-v4' into main
dimaMachina Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/olive-mice-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'graphiql': patch
'@graphiql/react': patch
---

Respect Markdown format: ignore single newline
4 changes: 3 additions & 1 deletion packages/graphiql-react/src/markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import MarkdownIt from 'markdown-it';

export const markdown = new MarkdownIt({
breaks: true,
// we don't want to convert \n to <br> because in markdown a single newline is not a line break
// https://github.com/graphql/graphiql/issues/3155
breaks: false,
linkify: true,
});