Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] move @graphiql/toolkit to devDependecies because umd build is bundled with all dependencies in one file #3675

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Aug 2, 2024

after #3655 (comment) I realized that there is no need to have @graphiql/toolkit in dependencies too

Copy link

changeset-bot bot commented Aug 2, 2024

🦋 Changeset detected

Latest commit: 077a2a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimaMachina dimaMachina requested a review from acao August 2, 2024 09:29
@acao
Copy link
Member

acao commented Aug 3, 2024

works for me!

@dimaMachina dimaMachina merged commit 676f910 into graphql:main Aug 3, 2024
11 of 12 checks passed
This was referenced Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants