Duplicate fields in deep inputs not validated properly (#1791) (#1792)

graphql · Mar 15, 2019 · a001adb · a001adb
1 parent b8eb8de
commit a001adb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/validation/__tests__/UniqueInputFieldNames-test.js b/src/validation/__tests__/UniqueInputFieldNames-test.js
@@ -88,4 +88,12 @@ describe('Validate: Unique input field names', () => {
       duplicateField('f1', 3, 22, 3, 48),
     ]);
   });
+
+  it('nested duplicate input object fields', () => {
+    expectErrors(`
+      {
+        field(arg: { f1: {f2: "value", f2: "value" }})
+      }
+    `).to.deep.equal([duplicateField('f2', 3, 27, 3, 40)]);
+  });
 });
diff --git a/src/validation/rules/UniqueInputFieldNames.js b/src/validation/rules/UniqueInputFieldNames.js
@@ -49,7 +49,6 @@ export function UniqueInputFieldNames(
       } else {
         knownNames[fieldName] = node.name;
       }
-      return false;
     },
   };
 }