Improve error message for missing required argument in field or directive #1554
Conversation
| @@ -27,7 +27,7 @@ export function missingFieldArgMessage( | |||
| ): string { | |||
| return ( | |||
| `Field "${fieldName}" argument "${argName}" of type ` + | |||
| `"${type}" is required but not provided.` | |||
| `"${type}" is required, but not provided.` | |||
There was a problem hiding this comment.
@everdimension Thanks for PR 👍
I'm not a native speaker myself but not provided looks like a dependent sentence for me so it looks like this sentence doesn't need comma based on this article:
https://www.grammarly.com/blog/comma-before-but/
There was a problem hiding this comment.
Neither am I, but this message seems a bit off for some reason.
After further investigation, it seems that the comma before "but" is not obligatory in the english language when the subject is not repeated in the second clause.
But now that I've had a second look, perhaps the problem is the omitted verb.
So the correct message should sound something like this:
"${type}" is required but was not provided.
or
"${type}" is required, but it was not provided. (with comma, because "it" is repeated in the second clause)
But again, perhaps omitting the auxiliary verb is permissible for system messages like this one.
Anyway, this is definitely a nitpick. I can update my PR and add was instead of the comma if you agree that this is an improvement. Otherwise feel free to close this
There was a problem hiding this comment.
@everdimension I like was variant 👍
Also would be great to also get it reviewed by a native speaker.
There was a problem hiding this comment.
The comma should not matter. I think it's a British-ism vs American-ism, and so I don't think it makes a big difference. Despite being an American-English-speaker, commas or not read mostly the same in this case.
I agree that the was variant is nicest.
IvanGoncharov
changed the title
IvanGoncharov
force-pushed
the
chore/provided-required-messages
branch
from
baaafd3 to
1765de8
Compare
|
@everdimension I changed it to |
No description provided.