Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade codemirror-graphql & graphiql #1345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade codemirror-graphql & graphiql #1345

wants to merge 1 commit into from

Conversation

vardhanapoorv
Copy link
Contributor

This PR is follow up to #1279 to get GraphQL playground ready for a release.

Changes proposed in this pull request:

  • Upgrade codemirror-graphql, graphiql, graphql

@acao
Copy link
Member

acao commented Sep 18, 2021 •
edited
Loading

Thanks for this! We plan on cutting another codemirror-graphql release very soon

the build issues are caused by some old dependencies - meros and fsevents, which aren’t compatible with node 14 now

I will circle back in a week or so

@vardhanapoorv
Copy link
Contributor Author

vardhanapoorv commented Sep 18, 2021 •
edited
Loading

Awesome thanks!
I will hold off the Electron upgrade change as well then till this gets merged.

@acao
Copy link
Member

acao commented Nov 9, 2021

oops! forgot about this one and created another PR with an electron upgrade as well, so it would work on my m1

@vardhanapoorv
Copy link
Contributor Author

vardhanapoorv commented Nov 9, 2021 •
edited
Loading

@acao no worries, let me know if I can help in anyway. Feel free to close this PR then, since you already have another PR which is more up-to-date.

Cearl03
Cearl03 approved these changes Nov 13, 2021
View reviewed changes
Copy link

@Cearl03 Cearl03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cearl03 Cearl03 Cearl03 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vardhanapoorv @acao @Cearl03