-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed unreachable endpoint spinner size #504
Conversation
Thanks for the PR! |
By another div, do you mean something like an inner/smaller pulse inside the bigger one ? Something like the second spinner on this page: http://tobiasahlin.com/spinkit/ |
Yes exactly what I mean. You also can use the second spinner from that page! |
Just pushed the changes you advised me. It currently looks like this. Update: Nevermind, just saw your comment on #516. The implementation doesn't look any better anyway IMO. I have to mess with interface PulseProps {
delay: boolean
}
const Pulse = withProps<PulseProps>()(styled.div)`
width: 16px;
height: 16px;
background-color: ${spinnerColor};
border-radius: 100%;
animation: ${bounceAnimation} 2s infinite ease-in-out;
-webkit-animation: ${bounceAnimation} 2s infinite ease-in-out;
animation-delay: ${p => p.delay ? '-1s' : '0s'};
-webkit-animation-delay: ${p => p.delay ? '-1s' : '0s'};
position: ${p => p.delay ? 'absolute' : 'relative'};
top: 0;
`
const SpinnerWrapper = styled.div`
position: relative;
margin: 6px;
`
const Spinner = () => (
<SpinnerWrapper>
<Pulse delay={false} />
<Pulse delay={true} />
</SpinnerWrapper>
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The playground gets better and better with PRs like this 👍
* Fixed unreachable endpoint spinner size * Changed 'unreachable endpoint' spinner animation and color
Fixes #499 .
Changes proposed in this pull request:
IMO, it looks very tiny now though, especially with the fade-out effect while it grows.