[v1.16.3] Sync with upstream #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashley Davis <[email protected]>
…6-dns [release-1.16] add IPv6 example for recursive DNS arg
Includes a lot of comments explaining how the maxima were calculated. This is _very_ conservative, and assumes we're dealing with RSA keys twice the size of what we actually allow as a maximum. From running the included benchmark it seems the pathological runtime is about 13617196ns (13ms) on an M2 Max which seems acceptable. Signed-off-by: Ashley Davis <[email protected]>
Signed-off-by: Ashley Davis <[email protected]>
Signed-off-by: Ashley Davis <[email protected]>
…-inputs [release-1.16] Restrict max size of PEM inputs
Signed-off-by: Ashley Davis <[email protected]>
[release-1.16] Bump go + base images
Setting renewBeforePercentage to x now makes the certificate renew when there is x percent of its duration left *before* its expiry. For example, if the validity duration of a certificate is 180 minutes, and renewBeforePercentage is set to 25, the certificate will renew after 135 minutes, i.e. when there is 25% of its duration left. This now means the behaviour is in accordance with the spec of renewBeforePercentage. Before this patch, the behaviour was reversed, whereby the certificate would renew *after* x percent of its duration, not *before*. For example, for a certificate valid for 180 minutes, it would renew after 45 minutes. Signed-off-by: Adam Sroka <[email protected]>
…k-7421-to-release-1.16 [release-1.16] Fix renewBeforePercentage to comply with its spec
Signed-off-by: Erik Godding Boye <[email protected]>
[release-1.16] Bump golang.org/x/net to address CVE-2024-45337 and CVE-2024-45338
Signed-off-by: Erik Godding Boye <[email protected]>
[release-1.16] Bump go to 1.23.4 and bump base images to latest available
Signed-off-by: Ashley Davis <[email protected]>
…pbase [release-1.16] Bump base images
sclevine
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sync cert manager with latest v1.16.3.
Re-generate files and test:
This release contains mostly dependency updates, etc. There were no conflicts whatsoever.
Diff with upstream: cert-manager/cert-manager@v1.16.3...gravitational:cert-manager:taras/v1.16.3
Issue to pay attention to: