Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blank line at start of yaml not valid #4703

Closed
kgtw opened this issue Nov 4, 2020 · 0 comments · Fixed by #51989
Closed

blank line at start of yaml not valid #4703

kgtw opened this issue Nov 4, 2020 · 0 comments · Fixed by #51989
Labels
inactive Items that have gone stale and are likely to be closed. tctl tctl - Teleport admin tool

Comments

@kgtw
Copy link
Contributor

kgtw commented Nov 4, 2020

Description

What happened:

if the start of any manifest contains a blank line, teleport cannot parse the file

error: creating resources of type "" is not supported

Example:


---
kind: role
version: 3
....

note the empty line, on line 1

What you expected to happen:

File to be parsed

How to reproduce it (as minimally and precisely as possible):

Have an empty line at the start of the file

Environment

  • Teleport version (use teleport version): Teleport Enterprise v4.3.7git:v4.3.7-0-g3687d398b go1.13.2

  • Tsh version (use tsh version): Teleport v4.3.5 git:v4.3.5-0-g122349e78 go1.13.2

  • OS (e.g. from /etc/os-release):

  • Where are you running Teleport? (e.g. AWS, GCP, Dedicated Hardware):

Browser environment

  • Browser Version (for UI-related issues):
  • Install tools:
  • Others:

Relevant Debug Logs If Applicable

  • tsh --debug
  • teleport --debug
programmerq added a commit to programmerq/teleport that referenced this issue Jul 7, 2021
Added tests for `tctl create`

I broke up the Create function to separate reading the resources to be created and actually processing the stream and doing the creates. This helps in implementing the tests in a performant way vs writing out an actual temp file or mocking os.stdin which can be platform dependent.

Fixes gravitational#4703
@programmerq programmerq added the tctl tctl - Teleport admin tool label Jul 7, 2021
@zmb3 zmb3 added the inactive Items that have gone stale and are likely to be closed. label Feb 8, 2025
zmb3 added a commit that referenced this issue Feb 9, 2025
zmb3 added a commit that referenced this issue Feb 9, 2025
zmb3 added a commit that referenced this issue Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Items that have gone stale and are likely to be closed. tctl tctl - Teleport admin tool
Projects
None yet
3 participants