Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] Update FIPS algorithms inline with upstream x/crypto/ssh proposed changes #36709

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

reedloden
Copy link
Contributor

Backport #36685 to branch/v15

changelog: Update FIPS algorithms to match proposed x/crypto/ssh changes

…hanges

`x/crypto/ssh` is adding a `fipsonly` mode (similar to `crypto/tls/fipsonly`) in
golang/go#64769. Once this has landed and been released, we'll swap to using it.
In the meantime, update our hardcoded algorithm set to match the algorithms listed
in https://go-review.googlesource.com/c/crypto/+/550515.

The only difference is that `aes192-ctr` is kept in `FIPSCiphers`, as it seems to be
approved by NIST SP 800-131A rev 2 (page 17).

Additionally, we now define a list of approved public key authentication algorithms for
SSH server connections. This isn't configurable for normal use case (yet), only handled
for FIPS builds.
@reedloden reedloden self-assigned this Jan 15, 2024
@reedloden reedloden requested review from espadolini and codingllama and removed request for espadolini January 15, 2024 18:00
@reedloden reedloden enabled auto-merge (squash) January 15, 2024 18:08
@reedloden reedloden disabled auto-merge January 15, 2024 18:30
@reedloden reedloden enabled auto-merge (squash) January 15, 2024 18:31
auto-merge was automatically disabled January 15, 2024 18:32

Merge queue setting changed

@reedloden reedloden enabled auto-merge January 15, 2024 18:35
@reedloden reedloden added this pull request to the merge queue Jan 15, 2024
Merged via the queue into branch/v15 with commit 9e365c2 Jan 15, 2024
31 checks passed
@reedloden reedloden deleted the bot/backport-36685-branch/v15 branch January 15, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants