-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignores resizes when a desktop has screen_size
set
#41198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`screen_size` is meant to be a static override of the screen size, however this property was mistakenly lost when #39819 was merged. This commit restores the behavior of `screen_size` by ignoring resizes when it is set.
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
ibeckermayer
commented
May 4, 2024
avatus
approved these changes
May 5, 2024
zmb3
approved these changes
May 6, 2024
probakowski
approved these changes
May 6, 2024
@ibeckermayer See the table below for backport results.
|
ibeckermayer
pushed a commit
that referenced
this pull request
May 6, 2024
* Ignores resizes when a desktop has `screen_size` set `screen_size` is meant to be a static override of the screen size, however this property was mistakenly lost when #39819 was merged. This commit restores the behavior of `screen_size` by ignoring resizes when it is set. * hasSizeOverride and //nolint
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
* Ignores resizes when a desktop has `screen_size` set `screen_size` is meant to be a static override of the screen size, however this property was mistakenly lost when #39819 was merged. This commit restores the behavior of `screen_size` by ignoring resizes when it is set. * hasSizeOverride and //nolint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screen_size
is meant to be a static override of the screen size, however this property was mistakenly lost when#39819 was merged.
This commit restores the behavior of
screen_size
by ignoring resizes when it is set.changelog: Fixes
screen_size
behavior.