migrate tsh common to aws sdk v2 #49449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
aws
github-actions
bot
added
size/md
tsh
greedy52
approved these changes
Nov 26, 2024
|
FYI, this was my attempt to convert sig v4 but i run into some blockers on aws app server handler that does reverse service lookup: |
GavinFrazar
changed the title
GavinFrazar
force-pushed
the
gavinfrazar/migrate-tsh-common-to-aws-sdk-v2
branch
from
2341b6f to
a03056f
Compare
tigrato
approved these changes
Dec 7, 2024
|
@GavinFrazar See the table below for backport results.
|
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14142
This PR migrates
tools/tsh/commonto AWS SDK v2.As part of this PR I've added a utility package to adapt AWS SDK v2 credential provider to v1, so that I don't have to migrate everything in
lib/srv/alpnproxy(etc) at once.