WebUI MFA methods refactor #49679
Merged
WebUI MFA methods refactor #49679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
force-pushed
the
joerger/unify-mfa-types
branch
2 times, most recently
from
7ae2721 to
e0ee68e
Compare
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
2 times, most recently
from
518f3ef to
7616ec7
Compare
Joerger
force-pushed
the
joerger/unify-mfa-types
branch
from
e0ee68e to
9755a70
Compare
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
from
7616ec7 to
e2afc8c
Compare
Joerger
added
no-changelog
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
from
e2afc8c to
e53c97c
Compare
avatus
approved these changes
Dec 4, 2024
Closed
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
3 times, most recently
from
12e84bd to
ad04916
Compare
gzdunek
approved these changes
Dec 5, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
from
ad04916 to
831528d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Joerger
added a commit
that referenced
this pull request
Dec 16, 2024
* Replace fetchWebAuthnChallenge with getChallenge. * Replace getWebauthnResponse with getMfaChallengeResponse. * Update getMfaChallengeResponse to take DeviceType and otp code. * lint fix. * Fix tests. * Fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace existing MFA methods which handle only
webauthnorotpto handle generic MFA challenges instead. This way we can add SSO MFA support with just one or two small changes.Depends on #49678
Prerequisite for SSO MFA changes (TODO).