Fixing node-join script for macos to support app bundles

[doggydogworld]

macOS distribution methods were updated to include Application Bundles for tsh.app and tctl.app replacing the standalone binaries. Other installation methods were updated for this change but this script was forgotten. The node join script should now successfully install on macOS.

Fixes #50171

changelog: Fixed a bug that prevented the node-join script from working on macOS.

[fheinecke]

Not critical because there's only one item, but this should be declared as an array if it's going to be used as one below.

[doggydogworld]

All other stuff got removed. I kept this as just a string to keep it consistent. The original TELEPORT_BINARY_LIST is a space separated list of tools and the loops are based on that.

[marcoandredinis]

I don't think we need any client tools when running this script 🤔
Installing client tools has their own docs.
AFAIK, this script is only meant to create a teleport service with ssh_service.enabled=true and have it join the cluster.

So, I would instead remove any client binary from the installation.

[doggydogworld]

I don't think we need any client tools when running this script 🤔 Installing client tools has their own docs. AFAIK, this script is only meant to create a teleport service with ssh_service.enabled=true and have it join the cluster.

So, I would instead remove any client binary from the installation.

Ah that's fair. I was following current convention for most of this since it was a regression for macOS after v17 release. To keep current functionality on Linux I can keep that and just remove the client libraries for macOS since that doesn't work right now (script will error on darwin).

[zmb3]

Let's try to get Marco's comments addressed so we can merge this soon.