DiscoveryConfigStatus: update even when no resource is found #50433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
marcoandredinis
force-pushed
the
marco/fix_discoveryconfigstatus_nomatcher
branch
from
0b9f6d7 to
a9ab5d1
Compare
espadolini
requested changes
Dec 19, 2024
marcoandredinis
force-pushed
the
marco/fix_discoveryconfigstatus_nomatcher
branch
3 times, most recently
from
730cad4 to
0ace00a
Compare
espadolini
approved these changes
Dec 19, 2024
marcoandredinis
force-pushed
the
marco/fix_discoveryconfigstatus_nomatcher
branch
2 times, most recently
from
74eed50 to
119ec30
Compare
Joerger
approved these changes
Dec 21, 2024
lib/utils/slices/slices.go
Outdated
| for _, t := range ts { | ||
| if s, include := fn(t); include { | ||
| ss = append(ss, s) | ||
| if _, ok := seen[s]; !ok { |
There was a problem hiding this comment.
suggestion: so it's readable
Suggested change
| if _, ok := seen[s]; !ok { | |
| if _, seen := seen[s]; !seen { |
There was a problem hiding this comment.
This redefines the seen identifier to be a boolean, and then we can't access the seen map.
I'll change it to found:
if _, found := seen[s]; !found {
seen[s] = struct{}{}
ss = append(ss, s)
}
During Auto Discover, when using a DiscoveryConfig, if no resources are found, the DiscoveryConfigStatus is not updated accordingly. This PR ensures that, even when no resources are found, the status will report so.
marcoandredinis
force-pushed
the
marco/fix_discoveryconfigstatus_nomatcher
branch
from
119ec30 to
0316455
Compare
|
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Jan 6, 2025
* DiscoveryConfigStatus: update even when no resource is found During Auto Discover, when using a DiscoveryConfig, if no resources are found, the DiscoveryConfigStatus is not updated accordingly. This PR ensures that, even when no resources are found, the status will report so. * use comparable instead of any for generic method * remove useless un-named function on PreFetchHooks * prevent call to ssm:SendCommand with 0 instances * rename var from ok to found
marcoandredinis
added a commit
that referenced
this pull request
Jan 6, 2025
* DiscoveryConfigStatus: update even when no resource is found During Auto Discover, when using a DiscoveryConfig, if no resources are found, the DiscoveryConfigStatus is not updated accordingly. This PR ensures that, even when no resources are found, the status will report so. * use comparable instead of any for generic method * remove useless un-named function on PreFetchHooks * prevent call to ssm:SendCommand with 0 instances * rename var from ok to found
marcoandredinis
added a commit
that referenced
this pull request
Jan 7, 2025
* DiscoveryConfigStatus: update even when no resource is found During Auto Discover, when using a DiscoveryConfig, if no resources are found, the DiscoveryConfigStatus is not updated accordingly. This PR ensures that, even when no resources are found, the status will report so. * use comparable instead of any for generic method * remove useless un-named function on PreFetchHooks * prevent call to ssm:SendCommand with 0 instances * rename var from ok to found
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
…#50766) * DiscoveryConfigStatus: update even when no resource is found During Auto Discover, when using a DiscoveryConfig, if no resources are found, the DiscoveryConfigStatus is not updated accordingly. This PR ensures that, even when no resources are found, the status will report so. * use comparable instead of any for generic method * remove useless un-named function on PreFetchHooks * prevent call to ssm:SendCommand with 0 instances * rename var from ok to found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Auto Discover, when using a DiscoveryConfig, if no resources are found, the DiscoveryConfigStatus is not updated accordingly.
This PR ensures that, even when no resources are found, the status will report so.
Demo:
There's also a fix for the EC2 flow where we could call
ssm:SendCommandwith 0 instances. This caused a bad reporting of the status.