[Web] Separate Auth Connector UI into dedicated pages #50749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
no-changelog
rudream
force-pushed
the
yassine/auth-connector-ui
branch
2 times, most recently
from
ee4039e to
89efbc5
Compare
avatus
reviewed
Jan 6, 2025
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
flyinghermit
reviewed
Jan 7, 2025
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/GitHubConnectorEditor.story.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/GitHubConnectorEditor.tsx
Outdated
Show resolved
Hide resolved
rudream
force-pushed
the
yassine/auth-connector-ui
branch
from
89efbc5 to
67a5875
Compare
rudream
force-pushed
the
yassine/auth-connector-ui
branch
from
67a5875 to
9d4248c
Compare
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/AuthConnectorEditorContent.tsx
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/GitHubConnectorEditor.story.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/GitHubConnectorEditor.story.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/GitHubConnectorEditor.tsx
Outdated
Show resolved
Hide resolved
avatus
approved these changes
Jan 15, 2025
flyinghermit
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Looks good, but before merging this PR, can we please address this comment to make reusable connector spec instead of duplicating them over #50749 (comment)
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/GitHubConnectorEditor.story.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectorEditor/index.ts
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/AuthConnectors/AuthConnectors.story.tsx
Outdated
Show resolved
Hide resolved
rudream
force-pushed
the
yassine/auth-connector-ui
branch
from
a55023d to
bf07ce5
Compare
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
rudream
added a commit
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of https://github.com/gravitational/teleport.e/issues/4989
ecounterpart: https://github.com/gravitational/teleport.e/pull/5789This PR adds separate dedicated pages for auth connectors to the UI, instead of the current flow which uses dialogs.
Figma designs: https://www.figma.com/design/v6GunK50D2VC7w7I2FBDNf/Access-(Management)?node-id=6862-43134&m=dev
Demo
Adding a new connector
Editing an existing connector