Workload Identity: Add workload-identity-api service
#50859
Merged
+1,415
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
added
no-changelog
strideynet
force-pushed
the
strideynet/tbot-workload-api-new-ux
branch
from
e5ddbfe to
b753e19
Compare
strideynet
force-pushed
the
strideynet/refactor-tbot-internals-around-attrs
branch
from
5eeb25c to
85accc5
Compare
strideynet
force-pushed
the
strideynet/tbot-workload-api-new-ux
branch
from
b753e19 to
1b58ca1
Compare
strideynet
force-pushed
the
strideynet/refactor-tbot-internals-around-attrs
branch
from
85accc5 to
68eebba
Compare
strideynet
changed the title
workload-identity-api serviceworkload-identity-api service
strideynet
changed the title
workload-identity-api serviceworkload-identity-api service
strideynet
force-pushed
the
strideynet/tbot-workload-api-new-ux
branch
from
4027530 to
907f813
Compare
strideynet
force-pushed
the
strideynet/refactor-tbot-internals-around-attrs
branch
from
68eebba to
467a4cb
Compare
GavinFrazar
approved these changes
Jan 14, 2025
Comment on lines
+28
to
+30
| var ( | ||
| _ ServiceConfig = &WorkloadIdentityAPIService{} | ||
| ) |
There was a problem hiding this comment.
Suggested change
| var ( | |
| _ ServiceConfig = &WorkloadIdentityAPIService{} | |
| ) |
From Effective Go:
The appearance of the blank identifier in this construct indicates that the declaration exists only for the type checking, not to create a variable. Don't do this for every type that satisfies an interface, though. By convention, such declarations are only used when there are no static conversions already present in the code, which is a rare event.
strideynet
force-pushed
the
strideynet/refactor-tbot-internals-around-attrs
branch
from
467a4cb to
bc2ce53
Compare
Base automatically changed from
strideynet/refactor-tbot-internals-around-attrs
to
master
January 15, 2025 12:42
strideynet
force-pushed
the
strideynet/tbot-workload-api-new-ux
branch
from
65cd987 to
b426d09
Compare
timothyb89
approved these changes
Jan 17, 2025
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Jan 17, 2025
* Add new config struct for `workload-identity-api` service * Add CLI command * Add API * Wire up API * Add framework of test * Rename label selectors for consistency * Rename for consistency * Add more assertions to TestBotWorkloadIdentityAPI * Add to command registry * Fix CLI flags
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
…#51157) * Workload Identity: Add `workload-identity-api` service (#50859) * Add new config struct for `workload-identity-api` service * Add CLI command * Add API * Wire up API * Add framework of test * Rename label selectors for consistency * Rename for consistency * Add more assertions to TestBotWorkloadIdentityAPI * Add to command registry * Fix CLI flags * cla check cla check cla check cla check cla check cla chec
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
* Add new config struct for `workload-identity-api` service * Add CLI command * Add API * Wire up API * Add framework of test * Rename label selectors for consistency * Rename for consistency * Add more assertions to TestBotWorkloadIdentityAPI * Add to command registry * Fix CLI flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #49986
As per RFD191: #49133
Depends on #50833