Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused servicecfg.Config.Console field #50944

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Remove unused servicecfg.Config.Console field #50944

merged 1 commit into from
Jan 13, 2025

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy added the no-changelog Indicates that a PR does not require a changelog entry label Jan 10, 2025
@rosstimothy rosstimothy mentioned this pull request Jan 10, 2025
Merged
@rosstimothy rosstimothy marked this pull request as ready for review January 10, 2025 15:05
@github-actions github-actions bot requested review from tcsc and timothyb89 January 10, 2025 15:06
codingllama
codingllama approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rosstimothy rosstimothy enabled auto-merge January 13, 2025 16:54
@rosstimothy rosstimothy added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit 852fc7d Jan 13, 2025
43 checks passed
@rosstimothy rosstimothy deleted the tross/config_console branch January 13, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@timothyb89 timothyb89 timothyb89 approved these changes

@marcoandredinis marcoandredinis marcoandredinis approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rosstimothy @marcoandredinis @timothyb89 @codingllama