Adds option to use ambient creds to IC integration config #51013
+547
−442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the option for the AWS Identity Center to draw its AWS client config (including credentials and roles to assume) from the Teleport processes' environment. This change only includes the modifications to the protobuf plugin settings. Actual functional changes are to follow.
tcsc
added
no-changelog
smallinsky
reviewed
Jan 14, 2025
Comment on lines
6816
to
6818
| // UseAmbientAwsCreds indicates that the integration should use the ambient | ||
| // AWS credentials rather than | ||
| bool use_ambient_aws_creds = 7; |
There was a problem hiding this comment.
Can we use an existing method to distinguish credentials?
Can we consider reusing the approach introduced in the Entra ID integration, as defined in the following file:
Link to code
In this integration, credentials are distinguished by SOURCE_OIDC and SOURCE_SYSTEM_CREDENTIALS.
WDYT ?
There was a problem hiding this comment.
Yeah, makes sense the number of times we've had to shift from a boolean to an enum when other options turn up.
flyinghermit
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Looks good once https://github.com/gravitational/teleport/pull/51013/files#r1914712365 is addressed.
smallinsky
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option for the AWS Identity Center to draw its AWS client
config (including credentials and roles to assume) from the Teleport
processes' environment.
This change only includes the modifications to the protobuf plugin
settings. Actual functional changes are to follow.