Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v17] WebDiscover: supports defining labels for Discover flows with single resource enroll #51038

Open
wants to merge 3 commits into
base: lisa/v17/backend-labels
Choose a base branch
from
Open

[v17] WebDiscover: supports defining labels for Discover flows with single resource enroll #51038

wants to merge 3 commits into from

Conversation

kimlisa
Copy link
Contributor

@kimlisa kimlisa commented Jan 14, 2025 •
edited
Loading

backports #50606 #50853 #50976 to branch/v17

manual, but all commits were cleanly cherry-picked

changelog: Adds support for defining labels in the web UI Discover flows for single resource enroll (server, applications, Kubernetes, EKS, RDS)

@kimlisa
WebDiscover: allow setting resource labels when enrolling single eks,…
0a538d2 
… rds, server, kube (#50606)
@kimlisa
WebDiscover: Allow setting labels when enrolling single web applicati…
c98489b 
…on (#50853)

* Allow labels for generic add web app flow

* Update test
@kimlisa
WebDiscover: allow setting labels when enrolling aws app (#50976)
306903f 
* WebDiscover: allow setting labels when enrolling aws app

* Address CRs
@kimlisa kimlisa changed the title Lisa/v17/frontend labels WebDiscover: supports defining labels for Discover flows with single resource enroll Jan 14, 2025
@github-actions github-actions bot requested review from ravicious and rudream January 14, 2025 19:46
@kimlisa kimlisa changed the base branch from branch/v17 to lisa/v17/backend-labels January 14, 2025 19:46
@kimlisa kimlisa changed the title WebDiscover: supports defining labels for Discover flows with single resource enroll [v17] WebDiscover: supports defining labels for Discover flows with single resource enroll Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudream rudream rudream approved these changes

@ravicious ravicious ravicious approved these changes

Assignees
No one assigned
Labels
backport size/lg ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimlisa @ravicious @rudream