Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overview/Prerequisites to Discover flows #51048

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thedevelopnik
Copy link
Contributor

@thedevelopnik thedevelopnik commented Jan 14, 2025

WIP up for early feedback.

Key questions:

  • Where does the content of pageItems live? We'll need the content for most of the discover flows. Could be central as in this component, or could be spread out to the flows themselves.
  • If it's centralized, how do I communicate to the Overview component which content to return? I need to get more familiar with the state available at the moment, i.e. does info like KubeMeta flow down into those pages?
  • The <Subheader> component adds a lot of space between it and the <ul> element. Design would prefer that space to be shrunk down and I agree. What's the best way for me to do that?

@thedevelopnik thedevelopnik requested a review from kimlisa January 14, 2025 22:46
Signed-off-by: Dave Sudia <[email protected]>
@thedevelopnik thedevelopnik self-assigned this Jan 15, 2025
Copy link
Contributor

@kimlisa kimlisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants