Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS IC: Add groups filter #51484

Merged
merged 7 commits into from
Jan 28, 2025
Merged

AWS IC: Add groups filter #51484

merged 7 commits into from
Jan 28, 2025

Conversation

smallinsky
Copy link
Contributor

@smallinsky smallinsky commented Jan 25, 2025 •
edited
Loading

What

Introduces the ability to specify filters for groups in the AWS Identity Center ) integration.
The GroupSyncLabelsFilter field allows user to define criteria for which groups can be imported during the enrollment flow.

Implementation:
https://github.com/gravitational/teleport.e/pull/5939

@smallinsky smallinsky force-pushed the smallinsky/aws-ic-group-filter branch from 2ac76cd to 61b3e6f Compare January 25, 2025 21:38
@smallinsky smallinsky added the no-changelog Indicates that a PR does not require a changelog entry label Jan 26, 2025
@smallinsky smallinsky marked this pull request as ready for review January 26, 2025 16:11
@smallinsky smallinsky force-pushed the smallinsky/aws-ic-group-filter branch 3 times, most recently from 5497ac9 to 83b2950 Compare January 27, 2025 10:44
@smallinsky smallinsky force-pushed the smallinsky/aws-ic-group-filter branch from 83b2950 to 91cfa2e Compare January 27, 2025 18:59
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from espadolini January 27, 2025 21:35
@tcsc
Copy link
Contributor

tcsc commented Jan 28, 2025

@marek - I have merged the filter with the protobuf types introduced in #51405. Please double-check before merging

@smallinsky smallinsky added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit 1c0ae9a Jan 28, 2025
44 checks passed
@smallinsky smallinsky deleted the smallinsky/aws-ic-group-filter branch January 28, 2025 11:58
@public-teleport-github-review-bot
Copy link

@smallinsky See the table below for backport results.

Branch Result
branch/v17 Failed

@smallinsky smallinsky mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyinghermit flyinghermit flyinghermit approved these changes

@kopiczko kopiczko kopiczko approved these changes

@mvbrock mvbrock mvbrock approved these changes

@tcsc tcsc tcsc approved these changes

@r0mant r0mant r0mant approved these changes

Assignees
No one assigned
Labels
aws-iam-identity-center backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@smallinsky @tcsc @r0mant @mvbrock @kopiczko @flyinghermit