fix superfluous response call for WS request #51493
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
when there is a wrong configured proxy before Teleport it fails to return a proper error during WebSocket connect operation because of response.WriteHeader duplicate call first call is happened in the websocket.Upgrader's `returnError` function after WS headers mismatch and it only sets status to 400 Bad Request without any text https://github.com/gorilla/websocket/blob/v1.5.3/server.go#L77 Teleport tries to set the response status but fails to do that: http: superfluous response.WriteHeader call and the main reason of the error (missing WS headers) is lost
adone
force-pushed
the
fix-ws-superfluous-response
branch
from
09d773a to
62ead74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what happened
we experienced some issues with WebSockets:
400 Bad Requestwithout any error text in bodyInvestigation
we traced the error and found where status 400 can be returned during
/webapi/sites/:site/connect/wscall:https://github.com/gorilla/websocket/blob/v1.5.3/server.go#L125
it turned out we had a wrong configured proxy before teleport
so teleport was receiving WS connect requests without WS headers
so the first
response.WriteHeadercall happens here:https://github.com/gorilla/websocket/blob/v1.5.3/server.go#L77
if
authnWsUpgrader.Erroris emptyhttp.Errorwill be used with just a status text (400 Bad Request)and the original error (missing WS headers) is lost
fix
the easiest fix is set
Errorfunction as empty function to prevent unplannedhttp.Errorcalleven the lib itself doing this https://github.com/gorilla/websocket/blob/v1.5.3/server.go#L299