Fix the fieldset structure #51510
Merged
Fix the fieldset structure #51510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ffe0554.
bl-nero
added
the
no-changelog
gzdunek
approved these changes
Jan 28, 2025
ravicious
approved these changes
Jan 28, 2025
| @@ -146,46 +146,42 @@ export function LabelsInput({ | |||
| const width = `${inputWidth}px`; | |||
| const inputSize = 'medium'; | |||
| return ( | |||
| <Fieldset gap={labels.length > 0 ? 2 : 1}> | |||
| <Stack gap={1}> | |||
There was a problem hiding this comment.
I was wondering how it broke the semantic structure of fieldset and legend, I managed to find that indeed:
The first element inside the fieldset must be a legend element, which provides a label or description for the group.
https://www.w3.org/TR/WCAG20-TECHS/H71.html
FWIW, I did a quick check and this could also be fixed by getting rid of this Stack and changing the gap on Fieldset to always be 2, with just a minimal difference in spacing compared to the original implementation while keeping spacing defined on parents and not individual children.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a change that was implemented during the code review of #51457, because it broke the semantic structure of fieldset and legend. The tests of the follow-up PR #51458 relied on this structure to identify fields by the legend.
This PR is intended to be backported to v17, v16, and v15 manually along with the backports of #51457.