-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v17] backport netiq implementation #51541
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the necessary protobuf changes to accomodate NetIQ plugin. Part of gravitational/access-graph#634 Signed-off-by: Tiago Silva <[email protected]>
* netiq: add access graph protobufs This PR introduces the necessary protobuf changes to accommodate Access Graph receiving NetIQ stream of changes. Part of gravitational/access-graph#634 Signed-off-by: Tiago Silva <[email protected]> * Update netiq.proto Co-authored-by: Gabriel Corado <[email protected]> --------- Signed-off-by: Tiago Silva <[email protected]> Co-authored-by: Gabriel Corado <[email protected]>
This PR exposes the `GetNetIq` method in `PluginStatus` interface to be used in `e`. Signed-off-by: Tiago Silva <[email protected]>
tigrato
added
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Jan 28, 2025
r0mant
approved these changes
Jan 29, 2025
gabrielcorado
approved these changes
Jan 29, 2025
* netiq: add plugin install prompt This PR adds the plugin prompt code to read the required parameters to create the netiq plugin. Part of gravitational/access-graph#634 Signed-off-by: Tiago Silva <[email protected]> * add license * Update netiq.go Co-authored-by: Gavin Frazar <[email protected]> * Update netiq.go Co-authored-by: Gavin Frazar <[email protected]> * Update netiq.go Co-authored-by: Gavin Frazar <[email protected]> * handle review comments * Apply suggestions from code review Co-authored-by: Gavin Frazar <[email protected]> * Apply suggestions from code review Co-authored-by: Gavin Frazar <[email protected]> * consolidate prompt methods --------- Signed-off-by: Tiago Silva <[email protected]> Co-authored-by: Gavin Frazar <[email protected]>
public-teleport-github-review-bot
bot
removed the request for review
from strideynet
January 29, 2025 19:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
no-changelog
Indicates that a PR does not require a changelog entry
size/lg
size/md
tctl
tctl - Teleport admin tool
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #50476 to branch/v17
Backport #50477 to branch/v17
Backport #51285 to branch/v17
Backport #51290 to branch/v17
Backport #51502 to branch/v17