Simplify lib/utils/aws #51627
Merged
Simplify lib/utils/aws #51627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
the
no-changelog
GavinFrazar
force-pushed
the
gavinfrazar/simplify-aws-sigv4-signing-utils-pkg
branch
from
f1aca30 to
b223177
Compare
github-actions
bot
added
application-access
database-access
rosstimothy
approved these changes
Jan 30, 2025
nklaassen
approved these changes
Jan 30, 2025
public-teleport-github-review-bot
bot
removed request for
gabrielcorado and
greedy52
Base automatically changed from
gavinfrazar/migrate-aws-session-to-sdk-v2
to
master
January 30, 2025 17:11
This eliminates the SigningService in favor of a free function SignRequest, which eliminates AWS credential loading and simplifies the AWS utils package. In the process of doing this refactor, the AWS app handler has been changed to use AWS SDK v2 to load its credentials as well.
GavinFrazar
force-pushed
the
gavinfrazar/simplify-aws-sigv4-signing-utils-pkg
branch
from
b223177 to
71ea35e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
GavinFrazar
deleted the
gavinfrazar/simplify-aws-sigv4-signing-utils-pkg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the SigningService in favor of a free function SignRequest, which eliminates AWS credential loading and simplifies the AWS utils package.
In the process of doing this refactor, the AWS app handler has been changed to use AWS SDK v2 to load its credentials as well.
This PR depends on and is stacked on top of another PR:
Part of #14142