Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Add x11 events #561

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Add x11 events #561

merged 1 commit into from
Jan 20, 2022

Conversation

kimlisa
Copy link
Contributor

@kimlisa kimlisa commented Jan 20, 2022

resolves #493

image

Directions to add events

This is how its normally defined in backend:

event = Event{
    Name: X11ForwardEvent,
    Code: X11ForwardCode,
}
  1. Add event code (event.name) to eventCodes from services/audit/types.ts
  2. Add event type (event.code) to our RawEvents type
  3. Add event formatter to our formatters from services/audit/makeEvent.ts
  4. Add a icon for event type to our EventIconMap from Audit/EventList/EventTypeCell.tsx
  5. Add fixtures (raw json) to events for storybooking Audit/fixtures/index.ts
  6. update snapshot

@kimlisa kimlisa requested review from Joerger and alex-kovoy January 20, 2022 20:02
@kimlisa kimlisa merged commit 31084c9 into master Jan 20, 2022
@kimlisa kimlisa deleted the lisa/add-x11-event branch January 20, 2022 20:25
kimlisa added a commit that referenced this pull request Jan 20, 2022
kimlisa added a commit that referenced this pull request Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing x11-forward event
2 participants