-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New path rendering #1327
New path rendering #1327
Conversation
@sb12 I am in favour of paths and tracks rendered similar to roads at this zoom level and it allows for a number of different lines and fills to extend the classifications of use and leaves a lot more single line options open for the other features that require single line rendering. |
@sb12 See https://github.com/gravitystorm/openstreetmap-carto/blob/master/CONTRIBUTING.md#editing-layers - it seems that you need to run |
Fixed. Thanks @mkoniecz |
Wildcards (like in
It is important decision whatever highway values should directly correspond to render style. What about unpaved highway=footway? What about paved tracks? Is it necessary to make clear whatever way is tagged as highway=track/path like it is done now? Personally I think it would be a good idea to use current highway=track style to render minor unpaved roads and highway=service for paved tracks. |
This will need further discussion as it is a large effecting change. I would like to see before and after pics. Not sure about fixing a style for paved for this one thing. I would prefer a integrated solution for all paved./unpaved ways. Probably best doing separate pull requests for each issue. |
I think this would need some more work - rendering foot/cycleways wider than tracks does not seem a good idea. Also make sure to test it in areas with very dense path mapping - like here. |
Thanks for your feedback.
For now I added all values that are mentioned in the wiki as paved (for some reason wood and metal are considered to be unpaved in the wiki?). But anyway:
I added the surface value because I wanted to get rid of the path controversies. (What's the difference between a path and a footway etc.)
For low zoom levels (e.g. <= 16) it might be an option to have the same style for all paths. This also solves the issue of cycleways being confused with rivers. The surface issue can be solved later then.
I agree that it does need more work, especially regarding tracks. But this pull request wasn't meant to be merged like it is, it was mainly supposed to be a base for discussion whether such a major change in style could solve the footway and path problems. If we agree that this might be a solution, the process would be probably like this:
Some before and after pictures:
|
These pictures are quite convincing for me, but I would also add a z=13 example - just for completeness. |
Thanks for the additional examples - i think the contrast on urban landuses is not sufficient and i also don't really like the dashed casing which seems quite disturbing and not really that readable. In general it seems to look quite reasonable in urban environments but much less so in for rural paths. Here the black dashed rendering currently used for highway=path seems to work quite well and it will be difficult to improve on that in a way that looks well readable on all kinds of background. |
Footways are significantly prettier and (for me) without readability lost. But cycleways are not recognizable (cycleway looks like footway with ditches). Rendering fill blue would make it river-like, so I see no obvious solution. Is it possible to make some before/after in rural area with low road and footway density? For now only z16 is presented - and it is in forest what makes it easier to notice white lines. Maybe it would be better to ignore highway=path and surface for now (it has many open questions, starting from "what should be considered as paved"). |
And thanks for this proposal, it is a really promising idea. |
Nice, I like the close-ups a lot already! For the record, here is the last time footways and cycleways have been changed and discussed at length: #747 |
See first picture of "Schwetzingen" in my last post.
Sorry I didn't really find a good rural area with paths and without forest in the area my database covers. The contrast on farmland is not very good, yet, especially on level 13 and 15, so this needs a bit more tweaking. Maybe for levels 13 to 15 it is enough to have a grey or light salmon line without casing.
Would it help to give footways and pedestrian roads a red (salmon) casing:
I'm also not that happy with the cycleways. See for example here they look like water features: A possible solution might be to make the blue less strong with the drawback that it is harder to distinguish between footways and cycleways. This way also the dashes for mixed cycle/footways might be less disturbing. See e.g. the German OSM Style for a reference: http://openstreetmap.de/karte.html?zoom=15&lat=48.99818&lon=8.3766&layers=B000TT |
Random untested (for now) idea: what about solid fill like light orange/pink/green or strong green?
Main result of this change is making map uglier. |
Thanks for the work so far. Some more comments:
|
Maybe bigger difference would be good but it is way better than current situation with massive difference in rendering despite minor difference in meaning (compared to other features). |
@mkoniecz: +1 |
I feel that we should focus most on the paved/unpaved tag, and bicyle routes. The bicycle=yes, foot=not combination seems a bit specialist for a general map. As does the segregated, non-segretad tag. My suggestion:
This drops the use of red (like highway=footway) entirely. |
Actually I like the current red dashed rendering of footways. It makes it really obvious that these ways can't be used by motor vehicles. Changing the style like suggested above makes the map look nicer, but it becomes less useful as footways look too similar to residential ways. |
Highway=pedestrian already looks more like residential ways, but I heard no complaints about it. |
I now updated the pull request:
Unfortunetely something went wrong while updating the PR and I cannot reopen it. Please see #1359 for the update. |
I've recently seen a lot of issues regarding cycleways, footways and stairs, so I thought what about a complete new rendering for paths similar to the German OSM Style.
This pull requests changes the following:
This solves the following issues:
... and probably some more
Some possible issues with this style:
Example images:
Low zoom:
![path_z14_karlsruhe](https://cloud.githubusercontent.com/assets/5783139/6314408/b90ce4aa-b9dd-11e4-93d2-0342b873c278.png)
High zoom:
![path_z17_kit](https://cloud.githubusercontent.com/assets/5783139/6314410/b90eae34-b9dd-11e4-90e5-1e9a926747a6.png)
Bridges:
![path_z18](https://cloud.githubusercontent.com/assets/5783139/6314407/b909dfbc-b9dd-11e4-8e73-806477e8978d.png)
Tunnels:
![path_z18_hbf](https://cloud.githubusercontent.com/assets/5783139/6314411/b913402a-b9dd-11e4-9142-f4da9e01ec95.png)
Bridleway / path high zoom:
![path_z18_bridleway](https://cloud.githubusercontent.com/assets/5783139/6314409/b90ded5a-b9dd-11e4-872d-339ae58fcecb.png)
This is just a suggestion and there is still some room for improvement (especially for bridlway and unpaved paths).
I just first wanted to see what people think about such a change before putting more work into it.
As this is my first major pull request for OSM carto I'm also very happy about any suggestions for code improvement.