-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework living street and pedestrian #1684
Conversation
Looks much better to me. I'd make the casing of living_street slightly darker, living_street's are hard to identify on lower zoomlevels when they run close to houses. |
I don't like violet for pedestrian areas, but I admit it's hard to come up with something sane (especially adding the living street to the equation), so I wouldn't complain too loud. 😄 Maybe it could be lighter a bit, if possible. However I'd like to know what about landuse=industrial? Isn't this new pedestrian color too close? Are there any places where this would clash somehow? |
highway=living_street is now closer to normal roads, rather than completely different (more than highway=pedestrian) make highway=pedestrian pinkish to make it different from other roads (it is better than rather ugly old colour for living street) In addition, on lower zooms living street is less visible on landuse=residential what is also beneficial - previously it was more visible than more important highway=residential. New reddish highway=pedestrian is now closer to highway=footway than before what is a good think but also closer to highway=primary what is a bad thing. But it is also more distanced from other road types, especially highway=residential/unclassified/road.
@kocio-pl Good idea, I found some locations using http://overpass-turbo.eu/s/aBf This situation is not typical but result is worse than expected. Probably these roads should be move closer to gray and further from pink. https://cloud.githubusercontent.com/assets/899988/8901062/fb2c5400-3445-11e5-807b-1799a987d8cc.png |
I like the living street change. I'm dubious on the pink for pedestrian area, I think the current one is better. Pink confusing people with industrial areas? |
Oh, I forgot that we have already 3 more or less similar redish landuse colors (industrial, commercial and retail) and one more getting closer (power devices), so the problem is even more complex... |
Tourist attraction is pink as well and it seems there would be a significant overlap between pedestrian areas and tourist attractions. |
In those 3 examples I think the color is not disturbing for me, but still too dark. I think some light shade of beige could work (probably something between the land color and the building color - or maybe lighter than the land? it's just wild guessing). |
Wasn't it proposed somewhere to use orange-ish tint? That would make sense, by analogy to footway. |
No please. There are several attempts to get rid of the red-dot style for footways (#1359, #https://github.com/matkoniecz/road-style-preview/issues/1) thus we should not further manifest it. |
Closing for now, I am working on a new version. |
highway=living_street is now closer to normal roads, rather than completely different (more than highway=pedestrian)
make highway=pedestrian pinkish to make it different from other roads (it is better than rather ugly old colour for living street)
In addition, on lower zooms living street is less visible on landuse=residential what is also beneficial - previously it was more visible than more important highway=residential.
New reddish highway=pedestrian is now closer to highway=footway than before what is a good think but also closer to highway=primary what is a bad thing. But it is also more distanced from other road types, especially highway=residential/unclassified/road.
It is slightly better with red used for more important road than highway=primary but I think that it is also clear improvement independently from other GSoC changes.
https://cloud.githubusercontent.com/assets/899988/8890346/7b32c3d0-32fe-11e5-84fe-ebe29083cc41.png
https://cloud.githubusercontent.com/assets/899988/8890349/7b720a9a-32fe-11e5-8b86-a023b8b23c12.png
https://cloud.githubusercontent.com/assets/899988/8890348/7b714d58-32fe-11e5-99b2-0b1bfffc3326.png
https://cloud.githubusercontent.com/assets/899988/8890352/7b73d726-32fe-11e5-947c-482e2fe39b51.png
https://cloud.githubusercontent.com/assets/899988/8890350/7b729b7c-32fe-11e5-9bc5-ce1b5cd7e7bd.png
https://cloud.githubusercontent.com/assets/899988/8890351/7b730a9e-32fe-11e5-99d6-9705c490034b.png
https://cloud.githubusercontent.com/assets/899988/8890347/7b52e2be-32fe-11e5-9eca-33663cc36829.png
https://cloud.githubusercontent.com/assets/899988/8890353/7b8f0366-32fe-11e5-9d77-b17e1751c728.png
https://cloud.githubusercontent.com/assets/899988/8890354/7b9136b8-32fe-11e5-8fdb-cfd327162d00.png
https://cloud.githubusercontent.com/assets/899988/8890355/7b925be2-32fe-11e5-8334-4763d8831c29.png
https://cloud.githubusercontent.com/assets/899988/8890356/7b93362a-32fe-11e5-98f5-9fca6a308e1f.png